[webkit-changes] [WebKit/WebKit] 904297: ASSERTION FAILED: renderer.needsLayout() in setFul...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 904297e85250cc4af6e4c3309f596f166ba3155b
      https://github.com/WebKit/WebKit/commit/904297e85250cc4af6e4c3309f596f166ba3155b
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-08-10 (Sat, 10 Aug 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderBlockFlow.cpp

  Log Message:
  -----------
  ASSERTION FAILED: renderer.needsLayout() in setFullRepaintOnParentInlineBoxLayerIfNeeded after 282082 at main
https://bugs.webkit.org/show_bug.cgi?id=277915

Reviewed by Fujii Hironori.

In 282082 at main, I made the incorrect assumption that the incoming renderer is always marked for layout (see RenderBlockFlow::layoutModernLines -> setFullRepaintOnParentInlineBoxLayerIfNeeded).
This is clearly not the case -and we can simply early return on clean renderers.

* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::setFullRepaintOnParentInlineBoxLayerIfNeeded):

Canonical link: https://commits.webkit.org/282090@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications