[webkit-changes] [WebKit/WebKit] c6cadb: [view-transitions] Implement DOM API necessary to ...

[Kiet Ho]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c6cadba6b01325cd2e8a3b35d8f0ef440ea97429
      https://github.com/WebKit/WebKit/commit/c6cadba6b01325cd2e8a3b35d8f0ef440ea97429
  Author: Kiet Ho <tho22 at apple.com>
  Date:   2024-08-10 (Sat, 10 Aug 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/with-types/types-in-pagereveal-and-pageswap-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-types-mutable-expected.txt
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources-output.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/bindings/js/WebCoreBuiltinNames.h
    M Source/WebCore/dom/Document+ViewTransition.idl
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    A Source/WebCore/dom/StartViewTransitionOptions.h
    A Source/WebCore/dom/StartViewTransitionOptions.idl
    A Source/WebCore/dom/ViewTransition+Types.idl
    M Source/WebCore/dom/ViewTransition.cpp
    M Source/WebCore/dom/ViewTransition.h
    A Source/WebCore/dom/ViewTransitionTypeSet.cpp
    A Source/WebCore/dom/ViewTransitionTypeSet.h
    A Source/WebCore/dom/ViewTransitionTypeSet.idl

  Log Message:
  -----------
  [view-transitions] Implement DOM API necessary to support :active-view-transition-type()
https://bugs.webkit.org/show_bug.cgi?id=277777
rdar://133419258

Reviewed by Tim Nguyen.

This commit sets up the necessary infrastructure on the JavaScript DOM
API side to support :active-view-transition-type(). This includes:
* Adding a new setting called ViewTransitionsTypeEnabled
* Extending Document.startViewTransition to additionally accept
  StartViewTransitionOptions
* Implementing the ViewTransitionTypeSet object
* Extending ViewTransition to include a `types` member of type
  ViewTransitionTypeSet.

* LayoutTests/TestExpectations: Removed one passing test.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/with-types/types-in-pagereveal-and-pageswap-expected.txt:
Rebaselined.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-types-mutable-expected.txt:
Rebaselined now that the test is passing.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Added new setting ViewTransitionsTypeEnabled
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
* Source/WebCore/dom/Document+ViewTransition.idl: Extended Document.startViewTransition
to additionally accept StartViewTransitionOptions.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::startViewTransition): Extended to accept StartViewTransitionOptions
and pass the types within the options to ViewTransition.
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/StartViewTransitionOptions.h: Added.
* Source/WebCore/dom/StartViewTransitionOptions.idl: Added.
* Source/WebCore/dom/ViewTransition+Types.idl: Added new member `types` of type
ViewTransitionTypeSet.
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::ViewTransition): Additionally accept a vector of types and pass it
to ViewTransitionTypeSet.
(WebCore::ViewTransition::createSamePage):
* Source/WebCore/dom/ViewTransition.h:
(WebCore::ViewTransition::types const):
(WebCore::ViewTransition::setTypes):
* Source/WebCore/dom/ViewTransitionTypeSet.cpp: Added.
(WebCore::ViewTransitionTypeSet::ViewTransitionTypeSet):
(WebCore::ViewTransitionTypeSet::initializeSetLike const):
(WebCore::ViewTransitionTypeSet::clearFromSetLike):
(WebCore::ViewTransitionTypeSet::addToSetLike):
(WebCore::ViewTransitionTypeSet::removeFromSetLike):
(WebCore::ViewTransitionTypeSet::has const):
* Source/WebCore/dom/ViewTransitionTypeSet.h: Added.
(WebCore::ViewTransitionTypeSet::create):
* Source/WebCore/dom/ViewTransitionTypeSet.idl: Added.

Canonical link: https://commits.webkit.org/282088@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications