[webkit-changes] [WebKit/WebKit] 8467cf: [Navigation] Add finished promise to NavigationTra...

[Patrick]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8467cf6fcc1de1cfa291c50575c4ec1b34387ed5
      https://github.com/WebKit/WebKit/commit/8467cf6fcc1de1cfa291c50575c4ec1b34387ed5
  Author: Patrick Griffis <pgriffis at igalia.com>
  Date:   2024-08-10 (Sat, 10 Aug 2024)

  Changed paths:
    A LayoutTests/http/wpt/navigation-api/transition-promises-expected.txt
    A LayoutTests/http/wpt/navigation-api/transition-promises.html
    M Source/WebCore/page/Navigation.cpp
    M Source/WebCore/page/Navigation.h
    M Source/WebCore/page/NavigationTransition.cpp
    M Source/WebCore/page/NavigationTransition.h

  Log Message:
  -----------
  [Navigation] Add finished promise to NavigationTransition
https://bugs.webkit.org/show_bug.cgi?id=277264

Reviewed by Alex Christensen.

This creates a promise in NavigationTransition and resolves it per the spec:

https://html.spec.whatwg.org/multipage/nav-history-apis.html#inner-navigate-event-firing-algorithm (Steps 32.4, 33.4.7)

A test case for success and error were added. The error one currently
fails but will work after #31463 lands.

* LayoutTests/http/wpt/navigation-api/transition-promises-expected.txt: Added.
* LayoutTests/http/wpt/navigation-api/transition-promises.html: Added.
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::rejectFinishedPromise):
(WebCore::Navigation::abortOngoingNavigation):
(WebCore::Navigation::innerDispatchNavigateEvent):
* Source/WebCore/page/Navigation.h:
* Source/WebCore/page/NavigationTransition.cpp:
(WebCore::NavigationTransition::NavigationTransition):
(WebCore::NavigationTransition::resolvePromise):
(WebCore::NavigationTransition::rejectPromise):
(WebCore::NavigationTransition::finished):
* Source/WebCore/page/NavigationTransition.h:

Canonical link: https://commits.webkit.org/282085@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications