[webkit-changes] [WebKit/WebKit] 697d09: Overlay Regions should be based on the EventRegion...

[Etienne Segonzac]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 697d0939fc72804e300294e60042d131c0426a12
      https://github.com/WebKit/WebKit/commit/697d0939fc72804e300294e60042d131c0426a12
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2024-08-10 (Sat, 10 Aug 2024)

  Changed paths:
    A LayoutTests/overlay-region/fixed-overlay-drawn-rect-expected.txt
    A LayoutTests/overlay-region/fixed-overlay-drawn-rect.html
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm

  Log Message:
  -----------
  Overlay Regions should be based on the EventRegion's bounds
https://bugs.webkit.org/show_bug.cgi?id=277854
<rdar://132863165>

Reviewed by Mike Wyrzykowski.

We were using composited bounds to position and size Overlay Regions,
and these sometimes do not match the drawn rect.
Instead, go back to using the EventRegion's bounds, that's what they are
for.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(configureScrollViewWithOverlayRegionsIDs):
Switch to using the node's EventRegion.

* LayoutTests/overlay-region/fixed-overlay-drawn-rect-expected.txt: Added.
* LayoutTests/overlay-region/fixed-overlay-drawn-rect.html: Added.
Add a test covering the case where the composited bounds are different
from the bounds.

Canonical link: https://commits.webkit.org/282080@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications