[webkit-changes] [WebKit/WebKit] 6a283f: Ellipsis box is not considered for background clip

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a283f41b053d7509e1cfa441b3f6b42adedf1a6
      https://github.com/WebKit/WebKit/commit/6a283f41b053d7509e1cfa441b3f6b42adedf1a6
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-08-09 (Fri, 09 Aug 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-ellipsis-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-ellipsis-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-ellipsis.html
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp
    M Source/WebCore/rendering/EllipsisBoxPainter.cpp

  Log Message:
  -----------
  Ellipsis box is not considered for background clip
https://bugs.webkit.org/show_bug.cgi?id=167406
rdar://94331006

Reviewed by Alan Baradlay.

For ellipses to show up in `background-clip: text` we need to paint them in the PaintPhase::TextClip phase,
and force the color to black.

* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-ellipsis-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-ellipsis-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-ellipsis.html: Added.
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp:
(WebCore::LayoutIntegration::InlineContentPainter::paintEllipsis):
* Source/WebCore/rendering/EllipsisBoxPainter.cpp:
(WebCore::EllipsisBoxPainter::paint):

Canonical link: https://commits.webkit.org/282066@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications