[webkit-changes] [WebKit/WebKit] f65446: Remove IPC to speak arbitrary text from WebPageProxy

Ryosuke Niwa noreply at github.com
Fri Aug 9 13:18:38 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f65446fd053075008c71f2d7428f775b927268e9
      https://github.com/WebKit/WebKit/commit/f65446fd053075008c71f2d7428f775b927268e9
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-08-09 (Fri, 09 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h

  Log Message:
  -----------
  Remove IPC to speak arbitrary text from WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=277840

Reviewed by Wenson Hsieh and Geoffrey Garen.

Handle the menu items to start and stop speaking text in the UI process side.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::speak): Deleted.
(WebKit::WebPage::stopSpeaking): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:

Canonical link: https://commits.webkit.org/282058@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list