[webkit-changes] [WebKit/WebKit] daa4b7: [UnifiedPDF] Pointer changes to I-beam when click/...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: daa4b7172b0c699b5fad357ce5c4c432318d86ba
      https://github.com/WebKit/WebKit/commit/daa4b7172b0c699b5fad357ce5c4c432318d86ba
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-08-08 (Thu, 08 Aug 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] Pointer changes to I-beam when click/dragging over non-selectable (bitmap) text
https://bugs.webkit.org/show_bug.cgi?id=277832
rdar://132030261

Reviewed by Tim Horton.

Currently, we freeze the cursor too eagerly on a drag selection. For
both non-selectable text, and drags which don't produce meaningful
selections, we should not be updating the cursor to be an I-beam, since
that cursor update indicates the presence of selected text.

This patch addresses the bug by gating the corresponding cursor update
behind a non-empty current selection.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::freezeCursorDuringSelectionDragIfNeeded):

Canonical link: https://commits.webkit.org/282033@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications