[webkit-changes] [WebKit/WebKit] 207db7: Check for runs of zero-bytes when linking Assemble...

Marcus Plutowski noreply at github.com
Thu Aug 8 14:55:38 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 207db7247e05a68f966c09dbd67c8a0a2ec5f522
      https://github.com/WebKit/WebKit/commit/207db7247e05a68f966c09dbd67c8a0a2ec5f522
  Author: Marcus Plutowski <achierius at gmail.com>
  Date:   2024-08-08 (Thu, 08 Aug 2024)

  Changed paths:
    M Source/JavaScriptCore/jit/ExecutableAllocator.h
    M Source/WTF/wtf/PlatformEnable.h

  Log Message:
  -----------
  Check for runs of zero-bytes when linking AssemblerBuffer on x86
https://bugs.webkit.org/show_bug.cgi?id=276913
rdar://132273853

Reviewed by Yijia Huang.

The goal here is to detect memory corruption of the AssemblerBuffer
prior to link-time. On ARM64E, these would be caught at link-time via
the ARM64EHash feature within AssemblerBuffer, but due to that feature
being ARM64-specific, on x86 the link would succeed, leaving the
corruption to surface only when the code is executed, which makes it
much more difficult to identify the root cause.

* Source/JavaScriptCore/jit/ExecutableAllocator.h:
(JSC::performJITMemcpy):
* Source/WTF/wtf/PlatformEnable.h:

Canonical link: https://commits.webkit.org/282011@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list