[webkit-changes] [WebKit/WebKit] fb8f23: [Cocoa] Move WebNSAttributedStringExtras from /mac...

Brent Fulgham noreply at github.com
Thu Aug 8 11:51:22 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fb8f23c2355d0dbc7826d7dfb00503d3153a3e1d
      https://github.com/WebKit/WebKit/commit/fb8f23c2355d0dbc7826d7dfb00503d3153a3e1d
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2024-08-08 (Thu, 08 Aug 2024)

  Changed paths:
    M Source/WebCore/PlatformMac.cmake
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    A Source/WebCore/platform/cocoa/WebNSAttributedStringExtras.h
    A Source/WebCore/platform/cocoa/WebNSAttributedStringExtras.mm
    M Source/WebCore/platform/graphics/cocoa/controls/ControlFactoryCocoa.mm
    R Source/WebCore/platform/mac/WebNSAttributedStringExtras.h
    R Source/WebCore/platform/mac/WebNSAttributedStringExtras.mm

  Log Message:
  -----------
  [Cocoa] Move WebNSAttributedStringExtras from /mac to /cocoa
https://bugs.webkit.org/show_bug.cgi?id=277718
<rdar://problem/133333907>

Reviewed by Aditya Keerthi.

The WebNSAttributedStringExtras.mm and WebNSAttributedStringExtras.h files are built
on all Cocoa targets, so hosting them in a Mac-specific subdirectory is misleading.

We also don't need to forward declare NSAttachmentCharacter, since this is API on all
platforms.

* Source/WebCore/PlatformMac.cmake:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/cocoa/WebNSAttributedStringExtras.h: Renamed from Source/WebCore/platform/mac/WebNSAttributedStringExtras.h.
* Source/WebCore/platform/cocoa/WebNSAttributedStringExtras.mm: Renamed from Source/WebCore/platform/mac/WebNSAttributedStringExtras.mm.
(WebCore::attributedStringByStrippingAttachmentCharacters):
* Source/WebCore/platform/graphics/cocoa/controls/ControlFactoryCocoa.mm:

Canonical link: https://commits.webkit.org/282003@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list