[webkit-changes] [WebKit/WebKit] c76015: [WPE][WebDriver] Missing the first touch tap

[Lauro Moura]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c76015a5f579820ee89484aff9f43e1a31be6d22
      https://github.com/WebKit/WebKit/commit/c76015a5f579820ee89484aff9f43e1a31be6d22
  Author: Lauro Moura <lmoura at igalia.com>
  Date:   2024-08-08 (Thu, 08 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp

  Log Message:
  -----------
  [WPE][WebDriver] Missing the first touch tap
https://bugs.webkit.org/show_bug.cgi?id=276874

Reviewed by Carlos Garcia Campos.

ViewPlatform stores the unhandled points in a HashMap for further
processing. The TouchDown handler code currently uses `hashMap->add`,
which does not overwrite the currently held value.

This behavior fails in WebDriver, where the PointerDown action doesn't
accept position coordinates, relying on a previous PointerMove action to
set WebDrivers input state with the right coordinates.

This commit changes the TouchDown handler to use `hashMap->set`,
allowing it to overwrite the previous event.

* Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp:
(WKWPE::ViewPlatform::handleEvent):

Canonical link: https://commits.webkit.org/281996@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications