[webkit-changes] [WebKit/WebKit] 9a7118: Adopt more smart pointers in accessibility table code

[Frédéric Wang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a71189f24d2a61b309ce67d5d5cb69295972649
      https://github.com/WebKit/WebKit/commit/9a71189f24d2a61b309ce67d5d5cb69295972649
  Author: Frédéric Wang <fwang at igalia.com>
  Date:   2024-08-08 (Thu, 08 Aug 2024)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityTable.cpp
    M Source/WebCore/accessibility/AccessibilityTableCell.cpp
    M Source/WebCore/accessibility/AccessibilityTableColumn.cpp
    M Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp
    M Source/WebCore/accessibility/AccessibilityTableRow.cpp

  Log Message:
  -----------
  Adopt more smart pointers in accessibility table code
https://bugs.webkit.org/show_bug.cgi?id=277072

Reviewed by Chris Dumez.

Use smart pointers in accessibility table code as indicated by
[alpha.webkit.UncountedCallArgsChecker] warnings. The choice of using a
smart pointer is motivated by the fact the following methods are not
trivial:

  - AXCoreObject::isTableCellInSameColGroup()
  - AXCoreObject::isTableCellInSameRowGroup()
  - AXObjectCache::getOrCreate()
  - AccessibilityNodeObject::parentObject()
  - AccessibilityObject::addChild()
  - AccessibilityObject::children()
  - AccessibilityTable::cellForColumnAndRow()
  - AccessibilityTable::columnHeaders()
  - AccessibilityTable::ensureCellIndexesUpToDate()
  - AccessibilityTable::rowCount()
  - AccessibilityTableCell::colSpan()
  - AccessibilityTableCell::isColumnHeader()
  - AccessibilityTableCell::rowSpan()
  - AccessibilityTableRow::axRowIndex()

* Source/WebCore/accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable const):
(WebCore::AccessibilityTable::addChildren):
* Source/WebCore/accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::parentTable const):
(WebCore::AccessibilityTableCell::columnHeaders):
(WebCore::AccessibilityTableCell::rowHeaders):
(WebCore::AccessibilityTableCell::ensureIndexesUpToDate const):
(WebCore::AccessibilityTableCell::axRowIndex const):
* Source/WebCore/accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::addChildren):
* Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::addChildren):
* Source/WebCore/accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::parentTable const):

Canonical link: https://commits.webkit.org/281982@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications