[webkit-changes] [WebKit/WebKit] 38e36f: Add the support for generating sharedPreferencesFo...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38e36fd479a284a1597097630ad87b2bc7bb9396
      https://github.com/WebKit/WebKit/commit/38e36fd479a284a1597097630ad87b2bc7bb9396
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-08-07 (Wed, 07 Aug 2024)

  Changed paths:
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in
    M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Scripts/webkit/model.py
    M Source/WebKit/Scripts/webkit/parser.py
    M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
    M Source/WebKit/Scripts/webkit/tests/MessageNames.cpp
    M Source/WebKit/Scripts/webkit/tests/MessageNames.h
    M Source/WebKit/Scripts/webkit/tests/TestWithEnabledBy.messages.in
    M Source/WebKit/Scripts/webkit/tests/TestWithEnabledByMessageReceiver.cpp
    M Source/WebKit/Scripts/webkit/tests/TestWithEnabledByMessages.h
    M Source/WebKit/Scripts/webkit/tests/TestWithEnabledIfMessageReceiver.cpp
    M Source/WebKit/UIProcess/WebProcessPool.messages.in

  Log Message:
  -----------
  Add the support for generating sharedPreferencesForWebProcess which takes connection
https://bugs.webkit.org/show_bug.cgi?id=277475

Reviewed by Chris Dumez.

This PR adds the support for SharedPreferencesNeedsConnection extended attribute on
an IPC message receiver which, if specified on a message receiver, will generate
sharedPreferencesForWebProcess calls with connection as an argument. Also changed
the delimiter for specifying multiple feature flags from "," to "&&".

In addition, this PR consolidates multiple calls to sharedPreferencesForWebProcess
in the generated didReceiveMessage function to one call at the beginning of
the function to avoid the overhead of calling the function multiple times.

Finally, use this new capability in WebProcessPool.messages.in.

* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in:
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
* Source/WebKit/Scripts/webkit/messages.py:
(generate_enabled_by):
(generate_runtime_enablement):
(async_message_statement):
(sync_message_statement):
(generate_enabled_by_for_receiver):
(generate_message_handler):
* Source/WebKit/Scripts/webkit/model.py:
(MessageReceiver.__init__):
(generate_global_model):
* Source/WebKit/Scripts/webkit/parser.py:
(parse):
* Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp:
(IPC::jsValueForArguments):
(IPC::messageArgumentDescriptions):
* Source/WebKit/Scripts/webkit/tests/MessageNames.cpp:
* Source/WebKit/Scripts/webkit/tests/MessageNames.h:
* Source/WebKit/Scripts/webkit/tests/TestWithEnabledBy.messages.in:
* Source/WebKit/Scripts/webkit/tests/TestWithEnabledByMessageReceiver.cpp:
(WebKit::TestWithEnabledBy::didReceiveMessage):
(IPC::jsValueForDecodedMessage<MessageName::TestWithEnabledBy_MultiConditionallyEnabled>):
* Source/WebKit/Scripts/webkit/tests/TestWithEnabledByMessages.h:
(Messages::TestWithEnabledBy::MultiConditionallyEnabled::name):
(Messages::TestWithEnabledBy::MultiConditionallyEnabled::arguments):
* Source/WebKit/Scripts/webkit/tests/TestWithEnabledIfMessageReceiver.cpp:
(WebKit::TestWithEnabledIf::didReceiveMessage):
* Source/WebKit/UIProcess/WebProcessPool.messages.in:

Canonical link: https://commits.webkit.org/281977@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications