[webkit-changes] [WebKit/WebKit] 425e83: webpushd should check that associated web clip has...

bnham noreply at github.com
Wed Aug 7 14:01:47 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 425e8378047cab03196f8f46e17871511342d2db
      https://github.com/WebKit/WebKit/commit/425e8378047cab03196f8f46e17871511342d2db
  Author: Ben Nham <nham at apple.com>
  Date:   2024-08-07 (Wed, 07 Aug 2024)

  Changed paths:
    M Source/WebKit/Platform/spi/Cocoa/UserNotificationsSPI.h
    M Source/WebKit/webpushd/WebPushDaemon.mm
    M Source/WebKit/webpushd/_WKMockUserNotificationCenter.h
    M Source/WebKit/webpushd/_WKMockUserNotificationCenter.mm

  Log Message:
  -----------
  webpushd should check that associated web clip has push permissions before subscribing on iOS
https://bugs.webkit.org/show_bug.cgi?id=277704
rdar://131362578

Reviewed by Chris Dumez.

We are moving permission management to webpushd on iOS. As part of this, we should also check that
the associated web clip has the appropriate permission before allowing them to create a Web Push
subscription. The embedder already does this check, but the daemon should verify this.

* Source/WebKit/Platform/spi/Cocoa/UserNotificationsSPI.h:
* Source/WebKit/webpushd/WebPushDaemon.mm:
(WebPushD::platformShouldPlaySound):
(WebPushD::platformDefaultActionBundleIdentifier):
(WebPushD::platformNotificationCenterBundleIdentifier):
(WebPushD::platformNotificationSourceForDisplay):
(WebPushD::WebPushDaemon::subscribeToPushService):
(WebPushD::WebPushDaemon::getPushPermissionState):
* Source/WebKit/webpushd/_WKMockUserNotificationCenter.h:
* Source/WebKit/webpushd/_WKMockUserNotificationCenter.mm:
(-[_WKMockUserNotificationCenter notificationSettings]):

Canonical link: https://commits.webkit.org/281958@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list