[webkit-changes] [WebKit/WebKit] e8ddea: Continue with HTTP load after showing HTTPSOnly wa...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e8ddea8b7dbdc63164ffcbf9704542f8e4e83af9
      https://github.com/WebKit/WebKit/commit/e8ddea8b7dbdc63164ffcbf9704542f8e4e83af9
  Author: Matthew Finkel <m_finkel at apple.com>
  Date:   2024-08-07 (Wed, 07 Aug 2024)

  Changed paths:
    M Source/WebCore/loader/cache/CachedResourceLoader.cpp
    M Source/WebKit/Shared/LoadParameters.h
    M Source/WebKit/Shared/LoadParameters.serialization.in
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm

  Log Message:
  -----------
  Continue with HTTP load after showing HTTPSOnly warning
https://bugs.webkit.org/show_bug.cgi?id=277713
rdar://133328571

Reviewed by Chris Dumez.

This change recovers from the failed provisional load by starting a new
navigation using HTTP, instead of HTTPS, after the user consents to continuing
with the fallback load.

This requires adjusting the URL scheme and propagating the fallback-state to
the FrameLoader. This change also fixes a bug in the fallback logic, so it
doesn't upgrade the request when we are attempting a fallback load.

* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):

Fixes a bug in the upgrade logic so we don't upgrade when we are falling back
to HTTP.

* Source/WebKit/Shared/LoadParameters.h:
* Source/WebKit/Shared/LoadParameters.serialization.in:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadRequestWithNavigationShared):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadRequest):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(TEST(WKNavigation, HTTPSOnlyHTTPFallbackContinue)):

Canonical link: https://commits.webkit.org/281945@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications