[webkit-changes] [WebKit/WebKit] 758bd9: Rename some FillBox values

Simon Fraser noreply at github.com
Tue Aug 6 13:06:31 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 758bd9fec6550454cd05fe76bd13b489668071b8
      https://github.com/WebKit/WebKit/commit/758bd9fec6550454cd05fe76bd13b489668071b8
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-08-06 (Tue, 06 Aug 2024)

  Changed paths:
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/rendering/BackgroundPainter.cpp
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderImage.cpp
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/style/FillLayer.cpp
    M Source/WebCore/rendering/style/FillLayer.h
    M Source/WebCore/rendering/style/RenderStyleConstants.cpp
    M Source/WebCore/rendering/style/RenderStyleConstants.h

  Log Message:
  -----------
  Rename some FillBox values
https://bugs.webkit.org/show_bug.cgi?id=277690
rdar://133306484

Reviewed by Tim Nguyen.

Once we have FillBox::BorderArea, the existing FillBox::Border is confusing, so rename to BorderBox,
PaddingBox, ContextBox.

* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::toCSSValueID):
(WebCore::fromCSSValueID):
* Source/WebCore/rendering/BackgroundPainter.cpp:
(WebCore::BackgroundPainter::paintFillLayer):
(WebCore::BackgroundPainter::calculateBackgroundImageGeometry):
(WebCore::BackgroundPainter::boxShadowShouldBeAppliedToBackground):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect const):
(WebCore::RenderBox::backgroundHasOpaqueTopLayer const):
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect const):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::backgroundRectForBox):
* Source/WebCore/rendering/style/FillLayer.cpp:
(WebCore::clipMax):
* Source/WebCore/rendering/style/FillLayer.h:
(WebCore::FillLayer::initialFillClip):
(WebCore::FillLayer::initialFillOrigin):
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:

Canonical link: https://commits.webkit.org/281907@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list