[webkit-changes] [WebKit/WebKit] aad1e9: Check whether overflowLayer is composited in appen...

[Frédéric Wang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aad1e95e11d2afc44bd5711895f099e7694c7e41
      https://github.com/WebKit/WebKit/commit/aad1e95e11d2afc44bd5711895f099e7694c7e41
  Author: Frédéric Wang <fwang at igalia.com>
  Date:   2024-08-06 (Tue, 06 Aug 2024)

  Changed paths:
    A LayoutTests/fast/scrolling/scroll-into-view-on-composited-scrollable-overflow-layer-crash-expected.txt
    A LayoutTests/fast/scrolling/scroll-into-view-on-composited-scrollable-overflow-layer-crash.html
    M Source/WebCore/rendering/RenderLayerCompositor.cpp

  Log Message:
  -----------
  Check whether overflowLayer is composited in appendOverflowLayerNodeID
https://bugs.webkit.org/show_bug.cgi?id=272972
rdar://126745401

Reviewed by Simon Fraser.

The call to appendOverflowLayerNodeID is conditioned on
hasCompositedScrollableOverflow() but as explained in r243908 that does
not guarantee that the layer is composited. Add a null-check in addition
to the debug ASSERT(overflowLayer.isComposited()), making this
consistent with updateScrollingNodeForScrollingProxyRole and
setupScrollProxyRelatedOverflowScrollingNode.

A non-regression test is added. In MiniBrowser, it is crashing without
the null-check, and it is still failing related debug ASSERTIONs. So far
it has always run normally in WebKitTestRunner though.

* LayoutTests/fast/scrolling/scroll-into-view-on-composited-scrollable-overflow-layer-crash-expected.txt: Added.
* LayoutTests/fast/scrolling/scroll-into-view-on-composited-scrollable-overflow-layer-crash.html: Added.
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::collectStationaryLayerRelatedOverflowNodes): Add a null-check and tweak log error.

Originally-landed-as: 277198.4 at webkit-2024.4-embargoed (9a7d6e22efa6). rdar://132955154
Canonical link: https://commits.webkit.org/281901@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications