[webkit-changes] [WebKit/WebKit] 33c82a: [JSC] Use simdutf for fromBase64

Yusuke Suzuki noreply at github.com
Tue Aug 6 11:05:56 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 33c82ad83b428e694d506ea257ed4e5277da9dfc
      https://github.com/WebKit/WebKit/commit/33c82ad83b428e694d506ea257ed4e5277da9dfc
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-08-06 (Tue, 06 Aug 2024)

  Changed paths:
    M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
    M Source/JavaScriptCore/Sources.txt
    R Source/JavaScriptCore/runtime/JSGenericTypedArrayView.cpp
    M Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h
    M Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructor.cpp
    M Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototype.cpp
    M Source/WTF/wtf/simdutf/simdutf_impl.cpp
    M Source/WTF/wtf/simdutf/simdutf_impl.h
    M Source/WTF/wtf/text/Base64.cpp
    M Source/WTF/wtf/text/Base64.h

  Log Message:
  -----------
  [JSC] Use simdutf for fromBase64
https://bugs.webkit.org/show_bug.cgi?id=277584
rdar://133101730

Reviewed by Yijia Huang.

This patch integrates simdutf into fromBase64.

1. When "strict" or "stop-before-partial" options are specified, we use fallback implementation[1]. Once they are implemented, we will switch to that.
2. Upgrade simdutf to fix issues found during implementing TC39 Base64 features.

[1]: https://github.com/simdutf/simdutf/issues/440

* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/Sources.txt:
* Source/JavaScriptCore/runtime/JSGenericTypedArrayView.cpp: Removed.
* Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h:
* Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/WTF/wtf/simdutf/simdutf_impl.cpp:
* Source/WTF/wtf/text/Base64.cpp:
(WTF::fromBase64SlowImpl):
(WTF::fromBase64Impl):
(WTF::fromBase64):
(WTF::maxLengthFromBase64):
* Source/WTF/wtf/text/Base64.h:

Canonical link: https://commits.webkit.org/281899@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list