[webkit-changes] [WebKit/WebKit] 846b4d: [WGSL] Type::alignment should work for primitive s...

Tadeu Zagallo noreply at github.com
Tue Aug 6 06:20:40 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 846b4dcaed697bf586d0a250ff23e658b6081777
      https://github.com/WebKit/WebKit/commit/846b4dcaed697bf586d0a250ff23e658b6081777
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-08-06 (Tue, 06 Aug 2024)

  Changed paths:
    M Source/WebGPU/WGSL/Types.cpp
    A Source/WebGPU/WGSL/tests/valid/array-primitive-struct.wgsl

  Log Message:
  -----------
  [WGSL] Type::alignment should work for primitive structs
https://bugs.webkit.org/show_bug.cgi?id=277634
rdar://132479662

Reviewed by Mike Wyrzykowski.

The alignment was only used for global variables, so the alignment would never
be computed for primitive structs. Since we started using alignment and size
for computing the limit of local variables, it needs to support primitive
structs as well.

* Source/WebGPU/WGSL/Types.cpp:
(WGSL::Type::alignment const):
* Source/WebGPU/WGSL/tests/valid/array-primitive-struct.wgsl: Added.

Canonical link: https://commits.webkit.org/281889@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list