[webkit-changes] [WebKit/WebKit] 40feeb: [GTK] Simplify the buffer handling in AcceleratedB...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 40feebf054198fe2b1685c4f375053c7471e6af3
      https://github.com/WebKit/WebKit/commit/40feebf054198fe2b1685c4f375053c7471e6af3
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-08-06 (Tue, 06 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp
    M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h

  Log Message:
  -----------
  [GTK] Simplify the buffer handling in AcceleratedBackingStoreDMABuf
https://bugs.webkit.org/show_bug.cgi?id=277678

Reviewed by Alejandro G. Castro.

We can simplify buffer handling if buffers have a weak reference to the
page and store the surfaceID they belong too. This way they can send the
ReleaseBuffer message only when needed and do the rendering, so we can
remove the Renderer class.

* Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:
(WebKit::AcceleratedBackingStoreDMABuf::~AcceleratedBackingStoreDMABuf):
(WebKit::AcceleratedBackingStoreDMABuf::Buffer::Buffer):
(WebKit::AcceleratedBackingStoreDMABuf::Buffer::deviceScaleFactor const):
(WebKit::AcceleratedBackingStoreDMABuf::Buffer::snapshot const):
(WebKit::AcceleratedBackingStoreDMABuf::Buffer::paint const):
(WebKit::AcceleratedBackingStoreDMABuf::Buffer::didRelease const):
(WebKit::AcceleratedBackingStoreDMABuf::BufferDMABuf::create):
(WebKit::AcceleratedBackingStoreDMABuf::BufferDMABuf::BufferDMABuf):
(WebKit::AcceleratedBackingStoreDMABuf::BufferDMABuf::release):
(WebKit::AcceleratedBackingStoreDMABuf::BufferEGLImage::create):
(WebKit::AcceleratedBackingStoreDMABuf::BufferEGLImage::BufferEGLImage):
(WebKit::AcceleratedBackingStoreDMABuf::BufferEGLImage::release):
(WebKit::AcceleratedBackingStoreDMABuf::BufferGBM::create):
(WebKit::AcceleratedBackingStoreDMABuf::BufferGBM::BufferGBM):
(WebKit::AcceleratedBackingStoreDMABuf::BufferGBM::didUpdateContents):
(WebKit::AcceleratedBackingStoreDMABuf::BufferGBM::release):
(WebKit::AcceleratedBackingStoreDMABuf::BufferSHM::create):
(WebKit::AcceleratedBackingStoreDMABuf::BufferSHM::BufferSHM):
(WebKit::AcceleratedBackingStoreDMABuf::BufferSHM::didUpdateContents):
(WebKit::AcceleratedBackingStoreDMABuf::BufferSHM::release):
(WebKit::AcceleratedBackingStoreDMABuf::didCreateBuffer):
(WebKit::AcceleratedBackingStoreDMABuf::didCreateBufferSHM):
(WebKit::AcceleratedBackingStoreDMABuf::unrealize):
(WebKit::AcceleratedBackingStoreDMABuf::update):
(WebKit::AcceleratedBackingStoreDMABuf::prepareForRendering):
(WebKit::AcceleratedBackingStoreDMABuf::snapshot):
(WebKit::AcceleratedBackingStoreDMABuf::paint):
(WebKit::AcceleratedBackingStoreDMABuf::Renderer::snapshot const): Deleted.
(WebKit::AcceleratedBackingStoreDMABuf::Renderer::paint const): Deleted.
* Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h:

Canonical link: https://commits.webkit.org/281886@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications