[webkit-changes] [WebKit/WebKit] 379142: Use OS_UNFAIR_LOCK_DATA_SYNCHRONIZATION and OS_UNF...

Yusuke Suzuki noreply at github.com
Mon Aug 5 12:41:01 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37914219bec20c62483b16dbac4d4e0b6d323bb9
      https://github.com/WebKit/WebKit/commit/37914219bec20c62483b16dbac4d4e0b6d323bb9
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-08-05 (Mon, 05 Aug 2024)

  Changed paths:
    M Source/bmalloc/libpas/src/libpas/pas_lock.h
    M Source/bmalloc/libpas/src/libpas/pas_platform.h

  Log Message:
  -----------
  Use OS_UNFAIR_LOCK_DATA_SYNCHRONIZATION and OS_UNFAIR_LOCK_ADAPTIVE_SPIN
https://bugs.webkit.org/show_bug.cgi?id=246373
rdar://101055626

Reviewed by Saam Barati.

>From the description of OS_UNFAIR_LOCK_DATA_SYNCHRONIZATION and OS_UNFAIR_LOCK_ADAPTIVE_SPIN[1], it looks good to use it in libpas.
So, this patch is just enabling them. Though we are not seeing any improvement / regression in benchmarks. Probably this is because
these locks are not contended anyway in libpas because libpas is designed to be extremely scalable (by deploying per-page locking when
it is contended).

[1]: https://opensource.apple.com/source/libplatform/libplatform-220.100.1/private/os/lock_private.h

* Source/bmalloc/libpas/src/libpas/pas_lock.h:
(pas_lock_lock):

Canonical link: https://commits.webkit.org/281849@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list