[webkit-changes] [WebKit/WebKit] 25af63: [CSS] Initial value for -webkit-line-clamp can't b...

Tim Nguyen noreply at github.com
Mon Aug 5 05:34:48 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 25af638fc712d1eb8b3b20929a5c89189a460660
      https://github.com/WebKit/WebKit/commit/25af638fc712d1eb8b3b20929a5c89189a460660
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-08-05 (Mon, 05 Aug 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/parsing/webkit-line-clamp-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-getPropertyValue-common-checks-expected.txt
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/CSSProperties.json

  Log Message:
  -----------
  [CSS] Initial value for -webkit-line-clamp can't be expressed with its grammar
https://bugs.webkit.org/show_bug.cgi?id=248638
rdar://103158259

Reviewed by Darin Adler and Oriol Brufau.

`line-clamp: none` is a valid value according to: https://drafts.csswg.org/css-overflow-4/#propdef-line-clamp

It also represents the behavior of the initial value of not clamping the lines.

Parse this value, so the default behavior of `-webkit-line-clamp` can be expressed via a CSS value.

* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/parsing/webkit-line-clamp-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-getPropertyValue-common-checks-expected.txt:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::fromCSSValue):
* Source/WebCore/css/CSSProperties.json:

Canonical link: https://commits.webkit.org/281826@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list