[webkit-changes] [WebKit/WebKit] e4f270: Use cascade alias for box-shadow/-webkit-box-shadow

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4f270fa0af131f33119d749b1d47c4182480538
      https://github.com/WebKit/WebKit/commit/e4f270fa0af131f33119d749b1d47c4182480538
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-08-05 (Mon, 05 Aug 2024)

  Changed paths:
    M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
    M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/svg/css/getComputedStyle-basic-expected.txt
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSShadowValue.cpp
    M Source/WebCore/css/CSSShadowValue.h
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
    M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  -----------
  Use cascade alias for box-shadow/-webkit-box-shadow
https://bugs.webkit.org/show_bug.cgi?id=277613
rdar://problem/133171521

Reviewed by Tim Nguyen.

Remove the last client of related-property mechanism.

* LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt:
* LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* Source/WebCore/css/CSSProperties.json:

Use cascade-alias.

* Source/WebCore/css/CSSShadowValue.cpp:
(WebCore::CSSShadowValue::CSSShadowValue):

Remember in CSSShadowValue whether this is a legacy -webkit-box-shadow.

(WebCore::CSSShadowValue::equals const):
* Source/WebCore/css/CSSShadowValue.h:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForShadow):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeSingleShadow):
(WebCore::CSSPropertyParserHelpers::consumeShadow):
(WebCore::CSSPropertyParserHelpers::consumeTextShadow):
(WebCore::CSSPropertyParserHelpers::consumeBoxShadow):
(WebCore::CSSPropertyParserHelpers::consumeWebkitBoxShadow):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyTextOrBoxShadowValue):

Use the saved bit when creating ShadowData.

(WebCore::Style::BuilderCustom::applyInitialWebkitBoxShadow): Deleted.
(WebCore::Style::BuilderCustom::applyInheritWebkitBoxShadow): Deleted.
(WebCore::Style::BuilderCustom::applyValueWebkitBoxShadow): Deleted.

No need for separate style builder path anymore.

Canonical link: https://commits.webkit.org/281823@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications