[webkit-changes] [WebKit/WebKit] ed167d: Use cascade-alias instead of related-property in C...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed167d83d75e6576619e1d72c55f61acfd66271e
      https://github.com/WebKit/WebKit/commit/ed167d83d75e6576619e1d72c55f61acfd66271e
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-08-04 (Sun, 04 Aug 2024)

  Changed paths:
    M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
    M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/svg/css/getComputedStyle-basic-expected.txt
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/process-css-properties.py
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/rendering/style/FillLayer.cpp

  Log Message:
  -----------
  Use cascade-alias instead of related-property in CSSProperties.json
https://bugs.webkit.org/show_bug.cgi?id=277591
rdar://133128418

Reviewed by Tim Nguyen.

It is a simpler and faster mechanism as it does not turn properties into deferred properties.

box-shadow/-webkit-box-shadow is the only remaining related-property pair. It requires a little bit of
refactoring.

* LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt:
* LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:

Aliases are not part of computed style enumeration.

* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/process-css-properties.py:
(StyleProperty.is_skipped_from_computed_style):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::exposedComputedCSSPropertyIDs):

Decide dynamically if the property is exposed as it may be affected by settings.

* Source/WebCore/rendering/style/FillLayer.cpp:
(WebCore::FillLayer::FillLayer):

The m_compositeSet bit was mistakenly always set for mask layers, preventing composite propagation
to other layers.

Canonical link: https://commits.webkit.org/281816@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications