[webkit-changes] [WebKit/WebKit] d3dd2b: Support closest-corner/farthest-corner in circle a...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d3dd2bfb693614ceecd21241a5036baab651877a
      https://github.com/WebKit/WebKit/commit/d3dd2bfb693614ceecd21241a5036baab651877a
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-08-03 (Sat, 03 Aug 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-closest-corner-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-closest-corner.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-farthest-corner-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-farthest-corner.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-closest-farthest-corner-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-closest-farthest-corner.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/reference/clip-path-ellipse-2-ref.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-computed.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-valid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/ellipse-function-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/ellipse-function-valid-expected.txt
    M Source/WebCore/css/BasicShapeConversion.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/rendering/style/BasicShapes.cpp
    M Source/WebCore/rendering/style/BasicShapes.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  Support closest-corner/farthest-corner in circle and ellipse shapes
https://bugs.webkit.org/show_bug.cgi?id=277454
rdar://132936677

Reviewed by Tim Nguyen.

Add support for the `closest-corner` and `farthest-corner` radial-size keywords to the `circle()` and `ellipse()` basic
shapes.

This is specified in https://drafts.csswg.org/css-shapes/ and https://drafts.csswg.org/css-images-4/#radial-size.

* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-closest-corner-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-closest-corner.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-farthest-corner-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-farthest-corner.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-closest-farthest-corner-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-closest-farthest-corner.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/reference/clip-path-ellipse-2-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-computed.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-valid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/ellipse-function-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/ellipse-function-valid-expected.txt:
* Source/WebCore/css/BasicShapeConversion.cpp:
(WebCore::basicShapeRadiusToCSSValue):
(WebCore::cssValueToBasicShapeRadius):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeShapeRadius):
* Source/WebCore/rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeCircle::floatValueForRadiusInBox const):
(WebCore::BasicShapeEllipse::floatSizeForRadiusInBox const):
(WebCore::operator<<):
* Source/WebCore/rendering/style/BasicShapes.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/281808@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications