[webkit-changes] [WebKit/WebKit] ba5aed: Unprefix -webkit-ruby-position

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ba5aedf5f753d40e7f3d45e56105762b7408d9ea
      https://github.com/WebKit/WebKit/commit/ba5aedf5f753d40e7f3d45e56105762b7408d9ea
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-08-03 (Sat, 03 Aug 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/inheritance-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/line-spacing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/parsing/ruby-position-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSToStyleMap.cpp
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/process-css-properties.py
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyleConstants.cpp
    M Source/WebCore/rendering/style/RenderStyleConstants.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/style/PropertyCascade.cpp
    M Tools/Scripts/webkitpy/style/checkers/jsonchecker.py

  Log Message:
  -----------
  Unprefix -webkit-ruby-position
https://bugs.webkit.org/show_bug.cgi?id=151306
rdar://86128259

Reviewed by Alan Baradlay.

Support `ruby-position` with the standard value names (over/under/inter-character) excluding 'alternate'.

* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/inheritance-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/line-spacing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/parsing/ruby-position-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::toCSSValueID):
(WebCore::fromCSSValueID):
* Source/WebCore/css/CSSProperties.json:

Add `ruby-position` and mark `-webkit-ruby-position` as its cascade alias.

Use the new cascade-alias mechanism as a simple alias does not work because the syntax differs
and the related-property mechanism can't be used as the property is marked top-priority.

The new mechanism replaces the existing 'synonym' mechanism that does not have correct behavior
when both synonyms are specified (the latter should override the earlier one). It was only used
by one property.

Also use the mechanism for -webkit-mask-source-type.

* Source/WebCore/css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillMaskMode):
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* Source/WebCore/css/process-css-properties.py:
(StylePropertyCodeGenProperties):
(StylePropertyCodeGenProperties.from_json):
(StyleProperty.perform_fixups_for_cascade_alias_properties):
(StyleProperty.perform_fixups):
(GenerateCSSPropertyNames):

Add support for cascade-alias mechanism.

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp:
(WebCore::Layout::InlineFormattingUtils::textEmphasisForInlineBox):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::rubyPosition):
(WebCore::Layout::RubyFormattingContext::placeAnnotationBox):
(WebCore::Layout::RubyFormattingContext::adjustLayoutBoundsAndStretchAncestorRubyBase):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:

Rename to match the standard naming.

* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::initialRubyPosition):
* Source/WebCore/style/PropertyCascade.cpp:
(WebCore::Style::PropertyCascade::addMatch):
* Tools/Scripts/webkitpy/style/checkers/jsonchecker.py:
(JSONCSSPropertiesChecker.check_codegen_properties):

Canonical link: https://commits.webkit.org/281804@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications