[webkit-changes] [WebKit/WebKit] c82e78: [cocoa] Add Continue button on warning view

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c82e784731d3ce16ffdb4d3e9f3158618184760f
      https://github.com/WebKit/WebKit/commit/c82e784731d3ce16ffdb4d3e9f3158618184760f
  Author: Matthew Finkel <m_finkel at apple.com>
  Date:   2024-08-02 (Fri, 02 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/BrowsingWarning.h
    M Source/WebKit/UIProcess/Cocoa/BrowsingWarningCocoa.mm
    M Source/WebKit/UIProcess/Cocoa/_WKWarningView.mm

  Log Message:
  -----------
  [cocoa] Add Continue button on warning view
https://bugs.webkit.org/show_bug.cgi?id=277529
rdar://133037364

Reviewed by Alex Christensen.

Adds support for a "Continue" button in the same place as the current "Show
Details" button when the warning is for a HTTPSNavigationFailure.

As part of this change, I'm storing the BrowsingWarning's Data parameter and
providing an accessor for it so we can identify the desired warning.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _showWarningViewWithURL:title:warning:detailsWithLinks:completionHandler:]):

This patch now requires explicitly declaring the warning type.

* Source/WebKit/UIProcess/BrowsingWarning.h:
(WebKit::BrowsingWarning::create):
(WebKit::BrowsingWarning::data const):
* Source/WebKit/UIProcess/Cocoa/BrowsingWarningCocoa.mm:
(WebKit::BrowsingWarning::BrowsingWarning):
* Source/WebKit/UIProcess/Cocoa/_WKWarningView.mm:
(colorForItem):
(makeButton):
(-[_WKWarningView addContent]):
(-[_WKWarningView continueClicked]):

Canonical link: https://commits.webkit.org/281796@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications