[webkit-changes] [WebKit/WebKit] 7f5aad: [UnifiedPDF] PDFPresentationController::updateForC...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f5aad034fe5a856ca4209d2b2dfa26efa9e3ddf
      https://github.com/WebKit/WebKit/commit/7f5aad034fe5a856ca4209d2b2dfa26efa9e3ddf
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-08-02 (Fri, 02 Aug 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] PDFPresentationController::updateForCurrentScrollability() should use the scrollability provided by callers
https://bugs.webkit.org/show_bug.cgi?id=277533
rdar://133042660

Reviewed by Tim Horton.

Currently, the discrete controller does not observe the updated
scrollability at all, while the scrolling controller asks the plugin to
compute scrollability, which is a duplication of work.

This patch addresses both of these issues.

Finally, we make UnifiedPDFPlugin::computeScrollability() private, since
this should not be called by the presentation controller.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm:
(WebKit::PDFDiscretePresentationController::updateForCurrentScrollability):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm:
(WebKit::PDFScrollingPresentationController::updateForCurrentScrollability):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::didChangeVisibleRow):

Ensure that the presentation controller accounts for scrollability of
the newly visible row.

Canonical link: https://commits.webkit.org/281775@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications