[webkit-changes] [WebKit/WebKit] cdadae: Remove and replace `Internals::setTopContentInset()`

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cdadae59887dbc28482d9cc7d1bc7eab4eb3d4b2
      https://github.com/WebKit/WebKit/commit/cdadae59887dbc28482d9cc7d1bc7eab4eb3d4b2
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-08-02 (Fri, 02 Aug 2024)

  Changed paths:
    M LayoutTests/fast/scrolling/latching/scroll-select-bottom-test.html
    M LayoutTests/fast/scrolling/mac/async-scroll-overflow-top-inset.html
    M LayoutTests/platform/mac-site-isolation/TestExpectations
    M LayoutTests/platform/mac-wk1/fast/backgrounds/top-content-inset-fixed-attachment.html
    M LayoutTests/platform/mac-wk2/accessibility/content-inset-scrollview-frame.html
    M LayoutTests/platform/mac/fast/events/content-inset-hit-testing-in-frame.html
    M LayoutTests/platform/mac/fast/events/content-inset-hit-testing.html
    M LayoutTests/scrollingcoordinator/mac/top-content-inset-to-zero.html
    M LayoutTests/tiled-drawing/scrolling/non-fast-region/top-content-inset-header.html
    M LayoutTests/tiled-drawing/scrolling/non-fast-region/top-content-inset.html
    M LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-body.html
    M LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-cover-expected.html
    M LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-cover-local-expected.html
    M LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-cover-local.html
    M LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-cover.html
    M LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-expected.html
    M LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-local-expected.html
    M LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-local.html
    M LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-positioned-expected.html
    M LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-positioned.html
    M LayoutTests/tiled-drawing/top-content-inset-fixed-attachment.html
    M LayoutTests/tiled-drawing/visible-rect-content-inset.html
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/C/WKPagePrivate.h
    M Source/WebKit/UIProcess/WebPageProxyTesting.cpp
    M Source/WebKit/UIProcess/WebPageProxyTesting.h
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
    M Source/WebKit/WebProcess/WebPage/WebPageTesting.cpp
    M Source/WebKit/WebProcess/WebPage/WebPageTesting.h
    M Source/WebKit/WebProcess/WebPage/WebPageTesting.messages.in
    M Source/WebKitLegacy/mac/WebView/WebView.mm
    M Source/WebKitLegacy/mac/WebView/WebViewPrivate.h
    M Tools/DumpRenderTree/TestRunner.cpp
    M Tools/DumpRenderTree/TestRunner.h
    M Tools/DumpRenderTree/mac/TestRunnerMac.mm
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
    M Tools/WebKitTestRunner/TestController.cpp

  Log Message:
  -----------
  Remove and replace `Internals::setTopContentInset()`
https://bugs.webkit.org/show_bug.cgi?id=277458
rdar://132944155

Reviewed by Alex Christensen.

`Internals::setTopContentInset()` tries to set the top content inset on the mainframe, which can’t
happen if it’s called from a site isolated iframe. This patch moves it to `TestRunner` and replaces it
with an async version of the function.

* LayoutTests/fast/scrolling/latching/scroll-select-bottom-test.html:
* LayoutTests/fast/scrolling/mac/async-scroll-overflow-top-inset.html:
* LayoutTests/platform/mac-site-isolation/TestExpectations:
* LayoutTests/platform/mac-wk1/fast/backgrounds/top-content-inset-fixed-attachment.html:
* LayoutTests/platform/mac-wk2/accessibility/content-inset-scrollview-frame.html:
* LayoutTests/platform/mac/fast/events/content-inset-hit-testing-in-frame.html:
* LayoutTests/platform/mac/fast/events/content-inset-hit-testing.html:
* LayoutTests/scrollingcoordinator/mac/top-content-inset-to-zero.html:
* LayoutTests/tiled-drawing/scrolling/non-fast-region/top-content-inset-header.html:
* LayoutTests/tiled-drawing/scrolling/non-fast-region/top-content-inset.html:
* LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-body.html:
* LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-cover-expected.html:
* LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-cover-local-expected.html:
* LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-cover-local.html:
* LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-cover.html:
* LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-expected.html:
* LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-local-expected.html:
* LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-local.html:
* LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-positioned-expected.html:
* LayoutTests/tiled-drawing/top-content-inset-fixed-attachment-positioned.html:
* LayoutTests/tiled-drawing/top-content-inset-fixed-attachment.html:
* LayoutTests/tiled-drawing/visible-rect-content-inset.html:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::setTopContentInset): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageSetTopContentInsetForTesting):
* Source/WebKit/UIProcess/API/C/WKPagePrivate.h:
* Source/WebKit/UIProcess/WebPageProxyTesting.cpp:
(WebKit::WebPageProxyTesting::setTopContentInset):
* Source/WebKit/UIProcess/WebPageProxyTesting.h:
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebPage/WebPageTesting.cpp:
(WebKit::WebPageTesting::setTopContentInset):
* Source/WebKit/WebProcess/WebPage/WebPageTesting.h:
* Source/WebKit/WebProcess/WebPage/WebPageTesting.messages.in:
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _setTopContentInsetForTesting:]):
* Source/WebKitLegacy/mac/WebView/WebViewPrivate.h:
* Tools/DumpRenderTree/TestRunner.cpp:
(setTopContentInsetCallback):
(TestRunner::staticFunctions):
* Tools/DumpRenderTree/TestRunner.h:
* Tools/DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setTopContentInset):
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setTopContentInset):
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveAsyncMessageFromInjectedBundle):

Canonical link: https://commits.webkit.org/281770@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications