[webkit-changes] [WebKit/WebKit] 5cdcca: [css-grid] Add FIXME about refactoring work to rem...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5cdcca7894c2c47dab457ce85721d8f927935c31
      https://github.com/WebKit/WebKit/commit/5cdcca7894c2c47dab457ce85721d8f927935c31
  Author: Brandon Stewart <brandonstewart at apple.com>
  Date:   2024-08-02 (Fri, 02 Aug 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderGrid.h

  Log Message:
  -----------
  [css-grid] Add FIXME about refactoring work to remove m_trackSizingAlgorithm from RenderGrid.h
https://bugs.webkit.org/show_bug.cgi?id=277497
rdar://problem/133003278

Reviewed by Sammy Gill.

Add FIXME to acknowledge needed work for a future refactor.

Sammy and I had a discussion over the last two days about removing m_trackSizingAlgorithm from RenderGrid.h and refactoring it to inside of layoutGrid and layoutMasonry.
This would allow a smaller scope of access to m_trackSizingAlgorithm and ensure that this object only survives during the layout step.
Several references to m_trackSizingAlgorithm are called deeply nested inside the layout functions, which would require propagation of object down the function stack.

* Source/WebCore/rendering/RenderGrid.h:

Canonical link: https://commits.webkit.org/281766@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications