[webkit-changes] [WebKit/WebKit] 2df148: [text-box-trim] Fix imported/w3c/web-platform-test...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2df1481dde2e76a154dbb66dde022d7927bec990
      https://github.com/WebKit/WebKit/commit/2df1481dde2e76a154dbb66dde022d7927bec990
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  [text-box-trim] Fix imported/w3c/web-platform-tests/css/css-inline/text-box-trim/text-box-trim-end-empty-line-001.html
https://bugs.webkit.org/show_bug.cgi?id=277457

Reviewed by Antti Koivisto.

We fail to identify the last line when hard line break pushed visually empty inline boxes to the next line (e.g. "this is last line<br><span></span>)
1. Add a static function isContentfulOrHasDecoration
2. Use this function throughout LineBuilder to ensure consistency

* LayoutTests/TestExpectations:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::isContentfulOrHasDecoration):
(WebCore::Layout::LineBuilder::leadingPunctuationWidthForLineCandiate const):
(WebCore::Layout::LineBuilder::trailingPunctuationOrStopOrCommaWidthForLineCandiate const):
(WebCore::Layout::LineBuilder::isLastLineWithInlineContent const):

Canonical link: https://commits.webkit.org/281745@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications