[webkit-changes] [WebKit/WebKit] 0c1617: Raindrop extension doesn't seem to be able to auth...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c16173ab63bb0b215559223635988bfa5be7c6d
      https://github.com/WebKit/WebKit/commit/0c16173ab63bb0b215559223635988bfa5be7c6d
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIPermissions.mm

  Log Message:
  -----------
  Raindrop extension doesn't seem to be able to authenticate.
https://webkit.org/b/277519
rdar://132912898

Reviewed by Jeff Miller and Brian Weinstein.

The CORS disabling patterns for the extension was not including optional host permissions due to
a copy-and-paste error (`allRequestedMatchPatterns()` vs `optionalPermissionMatchPatterns()`.)
Also corrected FIXME bug info to be more accurate.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::corsDisablingPatterns): Use optionalPermissionMatchPatterns().
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIPermissions.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIPermissions, CORS)): Added.

Canonical link: https://commits.webkit.org/281739@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications