[webkit-changes] [WebKit/WebKit] f1556c: Implement Observable#drop

Marais Rossouw noreply at github.com
Thu Aug 1 16:03:17 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1556cc6daef8bf209e079fa87369c76767fbf01
      https://github.com/WebKit/WebKit/commit/f1556cc6daef8bf209e079fa87369c76767fbf01
  Author: Marais Rossouw <me at marais.co>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-drop.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-drop.any.worker-expected.txt
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    A Source/WebCore/dom/InternalObserverDrop.cpp
    A Source/WebCore/dom/InternalObserverDrop.h
    M Source/WebCore/dom/Observable.cpp
    M Source/WebCore/dom/Observable.h
    M Source/WebCore/dom/Observable.idl

  Log Message:
  -----------
  Implement Observable#drop
https://bugs.webkit.org/show_bug.cgi?id=277224

Reviewed by Darin Adler.

This Pull Request implements the `drop` method for the `Observable`
class. This is required by the specification, for
[`#drop`](https://wicg.github.io/observable/#dom-observable-drop). Also adds
the `InternalObserverDrop` and `SubscriberCallbackDrop` to support this.

* LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-drop.any-expected.txt: Rebaselined.
* LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-drop.any.worker-expected.txt: Rebaselined.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/InternalObserverDrop.cpp: Added.
(WebCore::createSubscriberCallbackDrop):
* Source/WebCore/dom/InternalObserverDrop.h: Added.
* Source/WebCore/dom/Observable.cpp:
(WebCore::Observable::drop):
* Source/WebCore/dom/Observable.h:
* Source/WebCore/dom/Observable.idl:

Canonical link: https://commits.webkit.org/281734@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list