[webkit-changes] [WebKit/WebKit] ca9935: AX: lineTextMarkerRangeForTextMarker returns too m...

[Dominic Mazzoni]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ca993564405e47a71e87c0ef6f2605fb0ec88911
      https://github.com/WebKit/WebKit/commit/ca993564405e47a71e87c0ef6f2605fb0ec88911
  Author: Dominic Mazzoni <dm_mazzoni at apple.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M LayoutTests/accessibility/mac/line-text-marker-range-for-text-marker-expected.txt
    M LayoutTests/accessibility/mac/line-text-marker-range-for-text-marker.html
    M Source/WebCore/accessibility/AccessibilityObject.cpp

  Log Message:
  -----------
  AX: lineTextMarkerRangeForTextMarker returns too much text for some blank lines
https://bugs.webkit.org/show_bug.cgi?id=277489
rdar://132989539

Reviewed by Chris Fleizach.

In https://bugs.webkit.org/show_bug.cgi?id=275870 (AX:
lineTextMarkerRangeForTextMarker fails on first character of line in
Google Docs) we fixed an issue where lineTextMarkerRangeForTextMarker
failed to return a range at all.

This fix resulted in a regression where now it returns a range that's
too large, for some blank lines. One symptom was that when using
VoiceOver to arrow through editable text, landing on a blank line
would sometimes read the subsequent line rather than just "newline".

* LayoutTests/accessibility/mac/line-text-marker-range-for-text-marker-expected.txt:
* LayoutTests/accessibility/mac/line-text-marker-range-for-text-marker.html:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::lineRangeForPosition const):

Canonical link: https://commits.webkit.org/281724@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications