[webkit-changes] [WebKit/WebKit] fc46bb: Rename WKSafeBrowsingWarning to WKWarningView

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc46bbbaea29d6bc0c9d342e45c5e24fb3da0a63
      https://github.com/WebKit/WebKit/commit/fc46bbbaea29d6bc0c9d342e45c5e24fb3da0a63
  Author: Matthew Finkel <m_finkel at apple.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
    M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
    R Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.h
    R Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm
    A Source/WebKit/UIProcess/Cocoa/_WKWarningView.h
    A Source/WebKit/UIProcess/Cocoa/_WKWarningView.mm
    M Source/WebKit/UIProcess/mac/PageClientImplMac.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Rename WKSafeBrowsingWarning to WKWarningView
https://bugs.webkit.org/show_bug.cgi?id=277442
rdar://132924925

Reviewed by Alex Christensen.

Rename WKSafeBrowsingWarning, and associated state, to a more generic name.
This will be useful in future changes.

No other behavioral changes.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _showWarningView:completionHandler:]):
(-[WKWebView _showSafeBrowsingWarning:completionHandler:]):
(-[WKWebView _clearWarningView]):
(-[WKWebView _clearSafeBrowsingWarning]):
(-[WKWebView _clearWarningViewIfForMainFrameNavigation]):
(-[WKWebView _clearSafeBrowsingWarningIfForMainFrameNavigation]):
(-[WKWebView _showWarningViewWithTitle:warning:details:completionHandler:]):
(-[WKWebView _showSafeBrowsingWarningWithTitle:warning:details:completionHandler:]):
(-[WKWebView _showWarningViewWithURL:title:warning:details:completionHandler:]):
(-[WKWebView _showSafeBrowsingWarningWithURL:title:warning:details:completionHandler:]):
(-[WKWebView _showWarningViewWithURL:title:warning:detailsWithLinks:completionHandler:]):
(-[WKWebView _showSafeBrowsingWarningWithURL:title:warning:detailsWithLinks:completionHandler:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView layoutSubviews]):
(-[WKWebView _computedObscuredInsetForWarningView]):
(-[WKWebView safeAreaInsetsDidChange]):
(-[WKWebView _setObscuredInsets:]):
(-[WKWebView _safeBrowsingWarning]):
(-[WKWebView _computedObscuredInsetForSafeBrowsingWarning]): Deleted.
* Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:
(-[WKWebView setFrameSize:]):
(-[WKWebView _safeBrowsingWarning]):
* Source/WebKit/UIProcess/Cocoa/_WKWarningView.h: Renamed from Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.h.
* Source/WebKit/UIProcess/Cocoa/_WKWarningView.mm: Renamed from Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm.
(colorForItem):
(-[WKSafeBrowsingExclamationPoint drawRect:]):
(makeButton):
(-[_WKWarningViewBox setWarningViewBackgroundColor:]):
(-[_WKWarningView initWithFrame:safeBrowsingWarning:completionHandler:]):
(-[_WKWarningView addContent]):
(-[_WKWarningView showDetailsClicked]):
(-[_WKWarningView clickedOnLink:]):
(-[_WKWarningViewTextView initWithAttributedString:forWarning:]):
* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::showSafeBrowsingWarning):
(WebKit::PageClientImpl::hasSafeBrowsingWarning const):
(WebKit::PageClientImpl::clearSafeBrowsingWarning):
(WebKit::PageClientImpl::clearSafeBrowsingWarningIfForMainFrameNavigation):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::showWarningView):
(WebKit::WebViewImpl::clearWarningView):
(WebKit::WebViewImpl::clearWarningViewIfForMainFrameNavigation):
(WebKit::WebViewImpl::setFrameSize):
(WebKit::WebViewImpl::accessibilityAttributeValue):
(WebKit::WebViewImpl::nativeMouseEventHandlerInternal):
(WebKit::WebViewImpl::showSafeBrowsingWarning): Deleted.
(WebKit::WebViewImpl::clearSafeBrowsingWarning): Deleted.
(WebKit::WebViewImpl::clearSafeBrowsingWarningIfForMainFrameNavigation): Deleted.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/281715@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications