[webkit-changes] [WebKit/WebKit] b89ad8: [text-box-trim] Fix imported/w3c/web-platform-test...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b89ad82a33641db2235f6d78ca3e67aac4b0c74a
      https://github.com/WebKit/WebKit/commit/b89ad82a33641db2235f6d78ca3e67aac4b0c74a
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h

  Log Message:
  -----------
  [text-box-trim] Fix imported/w3c/web-platform-tests/css/css-inline/text-box-trim/text-box-trim-tall-line-001.html and text-box-trim-text-emphasis-start-001.html
https://bugs.webkit.org/show_bug.cgi?id=277443

Reviewed by Antti Koivisto.

1. Move text-box-trim functionality to a dedicated function
2. Instead of using layoutBounds, we can now use box geometry (mostly top/ascent/descent) as at this point
boxes are all positioned inside the line box. It helps to differentiate cases when line box is stretched by
a random atomic box (or replaced etc) or by line-height.
3. Stop adjusting non-root-inline-level-boxes. They are relative to the line box so any change in line box geometry
automatically moves them too.

* LayoutTests/TestExpectations:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::applyTextBoxTrimIfNeeded const):
(WebCore::Layout::LineBoxBuilder::computeLineBoxGeometry const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h:

Canonical link: https://commits.webkit.org/281702@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications