[webkit-changes] [WebKit/WebKit] 441201: REGRESSION(279663 at main): [GTK][WPE] layout-tests-r...

[Carlos Alberto Lopez Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4412011600505e6e65c646c532ff488d45f8800c
      https://github.com/WebKit/WebKit/commit/4412011600505e6e65c646c532ff488d45f8800c
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M Tools/CISupport/build-webkit-org/steps.py
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  REGRESSION(279663 at main): [GTK][WPE] layout-tests-repeat-failures step tries to run tests with unescaped filenames and that fails.
https://bugs.webkit.org/show_bug.cgi?id=277349

Reviewed by Carlos Garcia Campos.

Since 279663 at main the list of tests to repeat is passed to a shell via
"/bin/sh -c 'python3 run-webkit-tests --parameters long-list of-tests'",
But sometimes there are tests names with characters that confuse the shell
like for example:
  imported/w3c/web-platform-tests/html/dom/idlharness.https.html?exclude=(Document|Window|HTML.*)
  imported/w3c/web-platform-tests/html/dom/idlharness.https.html?include=HTML.*
So when one of this tests is scheduled for repeat the command does not execute
because the shell gives a syntax error.

In order to avoid this we should shlex.quote() all the parameters that are going
to be passed to the shell.

* Tools/CISupport/build-webkit-org/steps.py:
(RunJavaScriptCoreTests.run):
* Tools/CISupport/ews-build/steps.py:
(RunJavaScriptCoreTests.start):
(RunWebKitTests.start):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestRunWebKitTestsRepeatFailuresRedTree.test_success):
(TestRunWebKitTestsRepeatFailuresRedTree):
(TestRunWebKitTestsRepeatFailuresRedTree.test_success_tests_names_with_shell_conflictive_chars):

Canonical link: https://commits.webkit.org/281696@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications