[webkit-changes] [WebKit/WebKit] f8e2f4: ToPropertyKeyOrNumber incorrectly says it doesn't ...

[Keith Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8e2f45c2312e66f34db314a2ca054d0adaac66e
      https://github.com/WebKit/WebKit/commit/f8e2f45c2312e66f34db314a2ca054d0adaac66e
  Author: Keith Miller <keith_miller at apple.com>
  Date:   2024-04-29 (Mon, 29 Apr 2024)

  Changed paths:
    A JSTests/stress/ToPropertyKeyOrNumber-AI-should-include-number.js
    M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
    M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp

  Log Message:
  -----------
  ToPropertyKeyOrNumber incorrectly says it doesn't return a number in AI
https://bugs.webkit.org/show_bug.cgi?id=273429
rdar://127225001

Reviewed by Yusuke Suzuki.

Right now ToPropertyKeyOrNumber falls through to ToPropertyKey, which says it always
returns `SpecString | SpecSymbol`. This is obviously wrong.

* JSTests/stress/ToPropertyKeyOrNumber-AI-should-include-number.js: Added.
(opt.f):
(opt):
* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:

Canonical link: https://commits.webkit.org/278136@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications