[webkit-changes] [WebKit/WebKit] 40c054: [Site Isolation] Top content inset is incorrect af...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 40c054663111dac1e8af0d07618a5789d376d638
      https://github.com/WebKit/WebKit/commit/40c054663111dac1e8af0d07618a5789d376d638
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-04-29 (Mon, 29 Apr 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  [Site Isolation] Top content inset is incorrect after a cross-site navigation
https://bugs.webkit.org/show_bug.cgi?id=273379
rdar://127205664

Reviewed by Alex Christensen.

This was added a while ago in 259937 at main, and I’m not sure why. It’s causing page content to be
offset after a cross-site navigation because the top content inset sent to the destination process is
always zero.

This issue became more frequent after 275592 at main, because we started using these creation parameters
for main frame process swaps.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::creationParametersForRemotePage):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, TopContentInsetAfterCrossSiteNavigation)):

Canonical link: https://commits.webkit.org/278119@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications