[webkit-changes] [WebKit/WebKit] a3f9ca: [WPE] Platform: Fix crash on Wayland in DMA-BUF fe...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a3f9ca459d73096f2da94be8ca54d1b514f268eb
      https://github.com/WebKit/WebKit/commit/a3f9ca459d73096f2da94be8ca54d1b514f268eb
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2024-04-28 (Sun, 28 Apr 2024)

  Changed paths:
    M Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp

  Log Message:
  -----------
  [WPE] Platform: Fix crash on Wayland in DMA-BUF feedback handling
https://bugs.webkit.org/show_bug.cgi?id=273178

Reviewed by Carlos Garcia Campos.

Move creation of the pending DMABufFeedback into the "main_device"
handler, which according to the protocol should be the first one
in the sequence. Also, move reusing the previous FormatTable into the
"done" event callback, because at that point it is certain that there
will not be more related events coming.

The rest of the changes are needed to be able to create empty
FormatTable objects for the initial creation of new DMABufFeedback
instance, and being able move-assign it later.

* Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp:
(DMABufFeedback::FormatTable::FormatTable):
(DMABufFeedback::FormatTable::operator bool const):
(DMABufFeedback::FormatTable::operator=):
(DMABufFeedback::DMABufFeedback):
(DMABufFeedback::format):
(wpeViewWaylandGetPreferredDMABufFormats):
(DMABufFeedback::create): Deleted.

Canonical link: https://commits.webkit.org/278091@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications