[webkit-changes] [WebKit/WebKit] e808f2: AX: dfn element should map to AccessibilityRole::T...

Tyler Wilcock noreply at github.com
Sat Apr 27 20:51:15 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e808f25e438f9a1fd2ac9510797c66cb70730c32
      https://github.com/WebKit/WebKit/commit/e808f25e438f9a1fd2ac9510797c66cb70730c32
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-04-27 (Sat, 27 Apr 2024)

  Changed paths:
    M LayoutTests/accessibility/display-contents/element-roles-expected.txt
    M LayoutTests/accessibility/roles-computedRoleString.html
    M LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-expected.txt
    M LayoutTests/platform/glib/accessibility/display-contents/element-roles-expected.txt
    M LayoutTests/platform/ios/accessibility/display-contents/element-roles-expected.txt
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/html-aam/roles-expected.txt
    M LayoutTests/platform/mac-wk1/accessibility/aria-visible-element-roles-expected.txt
    M LayoutTests/platform/mac-wk1/accessibility/roles-exposed-expected.txt
    M LayoutTests/platform/mac-wk2/accessibility/aria-visible-element-roles-expected.txt
    M LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt
    M LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp

  Log Message:
  -----------
  AX: dfn element should map to AccessibilityRole::Term, as it indicates a term being defined, not a definition
https://bugs.webkit.org/show_bug.cgi?id=273357
rdar://problem/127166128

Reviewed by Chris Fleizach.

Confusingly, the `dfn` element represents a term being defined, making it equivalent to the "term" ARIA role rather
than the "definition" ARIA role. The "definition" ARIA role has no HTML equivalent.

https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-dfn-element
https://w3c.github.io/aria/#term and https://w3c.github.io/aria/#definition

This fixes one WPT subtest in html-aam/roles.html.

* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html-aam/roles-expected.txt:
* LayoutTests/platform/mac-wk1/accessibility/aria-visible-element-roles-expected.txt:
* LayoutTests/platform/mac-wk1/accessibility/roles-exposed-expected.txt:
* LayoutTests/platform/glib/accessibility/display-contents/element-roles-expected.txt:
* LayoutTests/platform/ios/accessibility/display-contents/element-roles-expected.txt:
* LayoutTests/accessibility/display-contents/element-roles-expected.txt:
* LayoutTests/accessibility/roles-computedRoleString.html:
* LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-expected.txt:
* LayoutTests/platform/mac-wk2/accessibility/aria-visible-element-roles-expected.txt:
* LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt:
* LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):

Canonical link: https://commits.webkit.org/278085@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list