[webkit-changes] [WebKit/WebKit] a6341c: Makefile.shared should pass SDKROOT to set-webkit-...

[Keith Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a6341cabd933197f63da3b9adcafed6dab5dd9e3
      https://github.com/WebKit/WebKit/commit/a6341cabd933197f63da3b9adcafed6dab5dd9e3
  Author: Keith Miller <keith_miller at apple.com>
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
    M Makefile.shared

  Log Message:
  -----------
  Makefile.shared should pass SDKROOT to set-webkit-configuration
https://bugs.webkit.org/show_bug.cgi?id=273320
rdar://127114398

Reviewed by David Kilzer.

This fixes the build scenario when Apple WebKittens try to do the OS build with
`make debug SDKROOT=macosx`. Previously we wouldn't forward the `SDKROOT` to
`set-webkit-configuration` which assumed the user wanted to use the .internal SDK.
This meant `set-webkit-configuration` would complain because it couldn't find
the Internal directory.

* Makefile.shared:

Canonical link: https://commits.webkit.org/278043@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications