[webkit-changes] [WebKit/WebKit] 56c9ce: Cherry-pick 275062 at main (c1a059873be7). https://bu...

Kristina Bessonova noreply at github.com
Fri Apr 26 00:53:21 PDT 2024


  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 56c9ce1a60cf039c616345a8c3995c1eec12352d
      https://github.com/WebKit/WebKit/commit/56c9ce1a60cf039c616345a8c3995c1eec12352d
  Author: Nicolò Ribaudo <nribaudo at igalia.com>
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
    M JSTests/es6/String.prototype_methods_String.prototype.normalize.js
    M Source/JavaScriptCore/runtime/StringPrototype.cpp

  Log Message:
  -----------
  Cherry-pick 275062 at main (c1a059873be7). https://bugs.webkit.org/show_bug.cgi?id=269783

    Normalize Latin-1 characters in `String#normalize("NFKC")``
    https://bugs.webkit.org/show_bug.cgi?id=269783

    Reviewed by Alexey Proskuryakov.

    The `String.prototype.normalize` implementation has a fast-path in
    cases where normalization does not affect the string. It was incorrectly
    assumed that NFKC does not affect 8-bit strings. The only normalization
    that doesn't affect them is NFC.

    * JSTests/es6/String.prototype_methods_String.prototype.normalize.js:
    (test):
    * Source/JavaScriptCore/runtime/StringPrototype.cpp:
    (JSC::normalize):
    (JSC::normalizationAffects8Bit): Deleted.

    Canonical link: https://commits.webkit.org/275062@main

Canonical link: https://commits.webkit.org/274313.164@webkitglib/2.44


  Commit: 9f979ae34d0c6654e52938076551077782326e8d
      https://github.com/WebKit/WebKit/commit/9f979ae34d0c6654e52938076551077782326e8d
  Author: Kristina Bessonova <kbessonova at accesssoftek.com>
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
    M Source/JavaScriptCore/heap/GCMemoryOperations.h

  Log Message:
  -----------
  Cherry-pick 275057 at main (a6fdfba9eced). https://bugs.webkit.org/show_bug.cgi?id=269785

    [JSC] Add missed "cc" inline asm clobber to ARM64 memory operations
    https://bugs.webkit.org/show_bug.cgi?id=269785

    Reviewed by Keith Miller.

    Since inline asm touches flags, it should set "cc" clobber to ensure
    a compiler will schedule instructions correctly.

    W/o the clobber and if compiled with clang v16 and newer (AArch64,
    Linux) may lead to a crash inside JSArray::unshiftCountSlowCase().

    * Source/JavaScriptCore/heap/GCMemoryOperations.h:
    (JSC::gcSafeMemcpy):
    (JSC::gcSafeMemmove):
    (JSC::gcSafeZeroMemory):

    Canonical link: https://commits.webkit.org/275057@main

Canonical link: https://commits.webkit.org/274313.165@webkitglib/2.44


Compare: https://github.com/WebKit/WebKit/compare/25e470331432...9f979ae34d0c

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list