[webkit-changes] [WebKit/WebKit] f3b5e7: [WebGPU] RenderPassEncoder should use WeakPtr in m...

Tadeu Zagallo noreply at github.com
Thu Apr 25 08:21:18 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f3b5e76d12f5e8c9eb8dbfea08f91f741290f856
      https://github.com/WebKit/WebKit/commit/f3b5e76d12f5e8c9eb8dbfea08f91f741290f856
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-04-25 (Thu, 25 Apr 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/webgpu/fuzz-126711484-expected.txt
    A LayoutTests/fast/webgpu/fuzz-126711484.html
    M Source/WebGPU/WebGPU/RenderBundle.h
    M Source/WebGPU/WebGPU/RenderBundle.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] RenderPassEncoder should use WeakPtr in more places
https://bugs.webkit.org/show_bug.cgi?id=273077
rdar://126711484

Reviewed by Mike Wyrzykowski.

This is very similar to 277742 at main, where the use of raw C++ pointers in the
descriptor can lead to UAF. In this case, we should also use the same WeakPtrs
created in the previous commit in `RenderBundle::validateRenderPass`.

* LayoutTests/fast/webgpu/fuzz-126711484-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-126711484.html: Added.
* Source/WebGPU/WebGPU/RenderBundle.h:
* Source/WebGPU/WebGPU/RenderBundle.mm:
(WebGPU::RenderBundle::validateRenderPass const):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executeBundles):

Canonical link: https://commits.webkit.org/277979@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list