[webkit-changes] [WebKit/WebKit] 493615: Cherry-pick 277325 at main (cb5290644a69). https://bu...

Wed Apr 24 00:56:42 PDT 2024

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 493615a8916f13e50db611b8de6939b90d23875c
      https://github.com/WebKit/WebKit/commit/493615a8916f13e50db611b8de6939b90d23875c
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2024-04-24 (Wed, 24 Apr 2024)

  Changed paths:
    A LayoutTests/svg/filters/filter-on-root-tile-boundary-expected.html
    A LayoutTests/svg/filters/filter-on-root-tile-boundary.html
    M Source/WebCore/platform/graphics/filters/FilterOperations.cpp
    M Source/WebCore/platform/graphics/filters/FilterOperations.h
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/svg/SVGRenderingContext.cpp

  Log Message:
  -----------
  Cherry-pick 277325 at main (cb5290644a69). https://bugs.webkit.org/show_bug.cgi?id=265465

    REGRESSION(267236 at main): SVG may incorrectly be clipped when an SVGFilter is applied to its root
    https://bugs.webkit.org/show_bug.cgi?id=265465
    rdar://118938065

    Reviewed by Nikolas Zimmermann.

    Ensure the SVGFilter is applied only once to the RenderSVGRoot through the SVG
    rendering code.

    But use the RenderLayerFilters to repaint the referenced SVGFilter clients when
    its effects are changed.

    * LayoutTests/svg/filters/filter-on-root-tile-boundary-expected.html: Added.
    * LayoutTests/svg/filters/filter-on-root-tile-boundary.html: Added.
    * Source/WebCore/platform/graphics/filters/FilterOperations.cpp:
    (WebCore::FilterOperations::isReferenceFilter const):
    * Source/WebCore/platform/graphics/filters/FilterOperations.h:
    * Source/WebCore/rendering/RenderLayer.cpp:
    (WebCore::RenderLayer::paintsWithFilters const):
    (WebCore::RenderLayer::calculateClipRects const):
    * Source/WebCore/rendering/svg/SVGRenderingContext.cpp:
    (WebCore::SVGRenderingContext::prepareToRenderSVGContent):

    Canonical link: https://commits.webkit.org/277325@main

Canonical link: https://commits.webkit.org/274313.158@webkitglib/2.44


  Commit: 13b88b35c299ee80058c524808d1c9bc07d29880
      https://github.com/WebKit/WebKit/commit/13b88b35c299ee80058c524808d1c9bc07d29880
  Author: Ahmad Saleem <ahmad.saleem792 at gmail.com>
  Date:   2024-04-24 (Wed, 24 Apr 2024)

  Changed paths:
    A LayoutTests/editing/execCommand/canvas-counter-rooteditable-crash-expected.txt
    A LayoutTests/editing/execCommand/canvas-counter-rooteditable-crash.html
    A LayoutTests/editing/pasteboard/paste-text-009-expected.txt
    M LayoutTests/editing/pasteboard/paste-text-009.html
    R LayoutTests/platform/gtk/editing/pasteboard/paste-text-009-expected.png
    R LayoutTests/platform/gtk/editing/pasteboard/paste-text-009-expected.txt
    R LayoutTests/platform/ios-simulator/editing/pasteboard/paste-text-009-expected.png
    M LayoutTests/platform/ios-wk2/editing/pasteboard/paste-text-009-expected.txt
    R LayoutTests/platform/mac/editing/pasteboard/paste-text-009-expected.png
    R LayoutTests/platform/mac/editing/pasteboard/paste-text-009-expected.txt
    R LayoutTests/platform/wincairo/editing/pasteboard/paste-text-009-expected.txt
    M Source/WebCore/editing/ReplaceSelectionCommand.cpp

  Log Message:
  -----------
  Cherry-pick 277291 at main (cb8d258708a5). https://bugs.webkit.org/show_bug.cgi?id=127684

    Convert an assertion to if-condition in `ReplaceSelectionCommand::doApply()`

    https://bugs.webkit.org/show_bug.cgi?id=127684
    rdar://problem/27685262

    Reviewed by Ryosuke Niwa.

    Merge: https://chromium.googlesource.com/chromium/src.git/+/8f313902e23e2589ddd9d3d2bfed8ee61e979f17

    This patch changes following assertion:

    `ASSERT(insertionBlock != currentRoot)`

    to if-condition in `ReplaceSelectionCommand::doApply()`, since we found a
    pattern to hit this assertion in "paste-text-009.html".

    This test changes current test to use 'testharness' script but instead of full
    merge from Blink commit, this limits it to only test change (i.e., 009.html).
    Only change is 'root' editable:

    "past-text-009.html": (testharness)
        |currentRoot| is "<div>one"
        | insertionBlock | is "<div>one"

      "paste-text-009.html":
        |currentRoot| is BODY
        | insertionBlock | is "<div>Omitted".

    * Source/WebCore/editing/ReplaceSelectionCommand.cpp:
    (ReplaceSelectionCommand::doApply):
    * LayoutTests/editing/pasteboard/paste-text-009.html: Rebaselined
    * LayoutTests/editing/pasteboard/paste-text-009-expected.txt: Add Test Expectation
    * LayoutTests/platform/gtk/editing/pasteboard/paste-text-009-expected.png: Removed
    * LayoutTests/platform/gtk/editing/pasteboard/paste-text-009-expected.txt: Ditto
    * LayoutTests/platform/ios/editing/pasteboard/paste-text-009-expected.png: Ditto
    * LayoutTests/platform/ios/editing/pasteboard/paste-text-009-expected.txt: Ditto
    * LayoutTests/platform/mac/editing/pasteboard/paste-text-009-expected.png: Ditto
    * LayoutTests/platform/mac/editing/pasteboard/paste-text-009-expected.txt: Ditto
    * LayoutTests/platform/wincairo/editing/pasteboard/paste-text-009-expected.txt: Ditto
    * LayoutTests/platform/ios/editing/pasteboard/paste-text-009-expected.txt: Add Platform Specific Expectation
    * LayoutTests/editing/execCommand/canvas-counter-rooteditable-crash.html: Add Test Case
    * LayoutTests/editing/execCommand/canvas-counter-rooteditable-crash-expected.txt: Add Test Case Expectation

    Canonical link: https://commits.webkit.org/277291@main

Canonical link: https://commits.webkit.org/274313.159@webkitglib/2.44


  Commit: d56aced2a2121efffcff963a8f44f862de03122c
      https://github.com/WebKit/WebKit/commit/d56aced2a2121efffcff963a8f44f862de03122c
  Author: David Degazio <d_degazio at apple.com>
  Date:   2024-04-24 (Wed, 24 Apr 2024)

  Changed paths:
    M Source/bmalloc/libpas/src/libpas/pas_enumerator.c

  Log Message:
  -----------
  Cherry-pick 277271 at main (8d6284de0e3f). https://bugs.webkit.org/show_bug.cgi?id=272404

    Addresses may not be persistent across calls to pas_enumerator_reader
    https://bugs.webkit.org/show_bug.cgi?id=272404
    rdar://125072587

    Reviewed by Yusuke Suzuki.

    Stores the results of calling the reader function in pas_enumerator_create
    locally as opposed to referencing the remote memory. This reduction in
    indirection means changes to the enumerating process' mapping of the remote
    memory will no longer cause values the enumerator is actively using (such
    as the pas_root) to become unmapped.

    * Source/bmalloc/libpas/src/libpas/pas_enumerator.c:
    (pas_enumerator_create):

    Canonical link: https://commits.webkit.org/277271@main

Canonical link: https://commits.webkit.org/274313.160@webkitglib/2.44


Compare: https://github.com/WebKit/WebKit/compare/2431b537193e...d56aced2a212

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications