[webkit-changes] [WebKit/WebKit] 619e39: Build failure with -Werror=overloaded-virtual on G...

[Carlos Bentzen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 619e39d2eab19c9e206788a0f351897b312cefb9
      https://github.com/WebKit/WebKit/commit/619e39d2eab19c9e206788a0f351897b312cefb9
  Author: Carlos Bentzen <cadubentzen at igalia.com>
  Date:   2024-04-23 (Tue, 23 Apr 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Network/WebSocketChannel.cpp
    M Source/WebKit/WebProcess/Network/WebSocketChannel.h

  Log Message:
  -----------
  Build failure with -Werror=overloaded-virtual on GCC 13
https://bugs.webkit.org/show_bug.cgi?id=273097

Reviewed by Darin Adler.

WebSocketChannel inherits from IPC::MessageSender which has a virtual sendMessage()
method. However, WebSocketChannel also had a private sendMessage() method which was
overloading IPC::MessageSender::sendMessage(). There is a warning for this with
-Woverloaded-virtual in GCC, which is included in -Wall on GCC 13. Coupled with -Werror,
we get a build failure in developer mode.

To fix this, renamed WebSocketChannel's sendMessage to sendMessageInternal.

* Source/WebKit/WebProcess/Network/WebSocketChannel.cpp:
(WebKit::WebSocketChannel::createMessageQueue):
(WebKit::WebSocketChannel::sendMessageInternal):
(WebKit::WebSocketChannel::sendMessage): Deleted.
* Source/WebKit/WebProcess/Network/WebSocketChannel.h:

Canonical link: https://commits.webkit.org/277904@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications