[webkit-changes] [WebKit/WebKit] bd4bbb: [YARR JIT] Intermittent crash when calling through...

[Michael Saboff]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd4bbbbc4c513f941a99773e53798cedb694b9c4
      https://github.com/WebKit/WebKit/commit/bd4bbbbc4c513f941a99773e53798cedb694b9c4
  Author: Michael Saboff <msaboff at apple.com>
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
    M Source/JavaScriptCore/jit/JITThunks.cpp
    M Source/JavaScriptCore/jit/JITThunks.h
    M Source/JavaScriptCore/yarr/YarrJIT.cpp
    M Source/JavaScriptCore/yarr/YarrJIT.h

  Log Message:
  -----------
  [YARR JIT] Intermittent crash when calling through areCanonicallyEquivalentThunk
https://bugs.webkit.org/show_bug.cgi?id=272862
rdar://126253524

Reviewed by Yusuke Suzuki.

THe speculation for the crash we are seeing is that there is a race condition where the thunk's code is not
properly synced across all thread.
Moved the generation of the recently added areCanonicallyEquivalent thunk to be a common thunk that is created
at VM initialization time.

* Source/JavaScriptCore/jit/JITThunks.cpp:
(JSC::JITThunks::initialize):
* Source/JavaScriptCore/jit/JITThunks.h:
* Source/JavaScriptCore/yarr/YarrJIT.cpp:
(JSC::Yarr::areCanonicallyEquivalentThunkGenerator):
* Source/JavaScriptCore/yarr/YarrJIT.h:

Canonical link: https://commits.webkit.org/277722@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications