[webkit-changes] [WebKit/WebKit] 8e0154: REGRESSION(264584 at main): Web Extension debug loggi...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e01542d58ad3d5c7370245d7cd460066215c3d1
      https://github.com/WebKit/WebKit/commit/8e01542d58ad3d5c7370245d7cd460066215c3d1
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
    M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  -----------
  REGRESSION(264584 at main): Web Extension debug logging is not being logged.
https://webkit.org/b/272918
rdar://problem/126708221

Reviewed by Per Arne Vollan.

os_log_set_hook takes a minimum log type, so set this to OS_LOG_TYPE_DEBUG for
debug builds. Also only return early for debug and info types in release builds.

This makes sure debug builds get all log message types. While release builds stay
mostly the same as before. However, info logs are now also filtered out, which was
the expected behavior before, but info logs were still getting sent.

* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::registerLogHook):

Canonical link: https://commits.webkit.org/277700@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications