[webkit-changes] [WebKit/WebKit] 57b120: REGRESSION [ iOS ] 5X TestWebKitAPI.CopyRTF.Strips...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 57b120b52e9486103826c045c2538ab4d1067d63
      https://github.com/WebKit/WebKit/commit/57b120b52e9486103826c045c2538ab4d1067d63
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/C/WKPreferences.cpp
    M Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm

  Log Message:
  -----------
  REGRESSION [ iOS ] 5X TestWebKitAPI.CopyRTF.Strips are crashing and failing
https://bugs.webkit.org/show_bug.cgi?id=272239

Reviewed by Wenson Hsieh.

The test failures are caused because nsattributedstringagent which gets launched by TestWebKitAPI
loads locally built WebKit but then launched WebContent process, networking process, etc... without
setting `__XPC_DYLD_FRAMEWORK_PATH` and `__XPC_DYLD_LIBRARY_PATH`.

Fix the tests by enabling WriteRichTextDataWhenCopyingOrDragging to trigger the legacy behavior.

* Source/WebKit/UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetWriteRichTextDataWhenCopyingOrDragging):
(WKPreferencesGetWriteRichTextDataWhenCopyingOrDragging):
* Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm:
(copyAttributedStringFromHTML):

Canonical link: https://commits.webkit.org/277655@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications