[webkit-changes] [WebKit/WebKit] c2fb38: Change LocalFrameView* to a reference in `PopupMen...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2fb38fa01e93ab76eab178d4c93b78eed0b6d43
      https://github.com/WebKit/WebKit/commit/c2fb38fa01e93ab76eab178d4c93b78eed0b6d43
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M Source/WebCore/loader/EmptyClients.cpp
    M Source/WebCore/platform/PopupMenu.h
    M Source/WebCore/rendering/RenderMenuList.cpp
    M Source/WebCore/rendering/RenderSearchField.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.h
    M Source/WebKitLegacy/ios/WebCoreSupport/PopupMenuIOS.h
    M Source/WebKitLegacy/ios/WebCoreSupport/PopupMenuIOS.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.h
    M Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm

  Log Message:
  -----------
  Change LocalFrameView* to a reference in `PopupMenu::show()`
https://bugs.webkit.org/show_bug.cgi?id=272725
rdar://126529496

Reviewed by Alex Christensen.

The LocalFrameView passed to this function cannot be null.

* Source/WebCore/loader/EmptyClients.cpp:
* Source/WebCore/platform/PopupMenu.h:
* Source/WebCore/rendering/RenderMenuList.cpp:
(RenderMenuList::showPopup):
* Source/WebCore/rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::showPopup):
* Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::show):
* Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.h:
* Source/WebKitLegacy/ios/WebCoreSupport/PopupMenuIOS.h:
* Source/WebKitLegacy/ios/WebCoreSupport/PopupMenuIOS.mm:
(PopupMenuIOS::show):
* Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.h:
* Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm:
(PopupMenuMac::show):

Canonical link: https://commits.webkit.org/277557@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications