[webkit-changes] [WebKit/WebKit] 50bb1b: [Unified PDF] find-in-page highlights can get deta...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 50bb1b20d213353ede7449797bfdc0850fcbc6c8
      https://github.com/WebKit/WebKit/commit/50bb1b20d213353ede7449797bfdc0850fcbc6c8
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [Unified PDF] find-in-page highlights can get detached from the document
https://bugs.webkit.org/show_bug.cgi?id=272710
rdar://125787367

Reviewed by Tim Horton.

In cases where we zoom but do not end up changing the scroll offset we
need to update our find overlay to repaint the rects correctly.

Also, whenever we zoom we need to hide the find indicator that showcases
the current selection to match shipping behavior in web content. We
should also adopt this logic whenever the scroll offset changes.
Otherwise you could find yourself in scenarios where the holes get
updated properly but the text indicator for the current selection does
not.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::setPageScaleFactor):
(WebKit::UnifiedPDFPlugin::didChangeScrollOffset):
(WebKit::UnifiedPDFPlugin::collectFindMatchRects):
(WebKit::UnifiedPDFPlugin::updateFindOverlay):

Canonical link: https://commits.webkit.org/277551@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications